-
-
Notifications
You must be signed in to change notification settings - Fork 483
refactor: ♻️ Replace utils.deprecated with warnings(/typing_extensions).deprecated
#3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3042/head:pr-3042
git checkout pr-3042This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3042/head |
utils.deprecated with typing(_extensions).deprecatedutils.deprecated with typing(_extensions).deprecated
utils.deprecated with typing(_extensions).deprecatedutils.deprecated with warnings(/typing_extensions).deprecated
| - Migrated away from `utils.deprecated` in favor of `warnings.deprecated` for | ||
| deprecation warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Migrated away from `utils.deprecated` in favor of `warnings.deprecated` for | |
| deprecation warnings. | |
| - Deprecated `utils.deprecated` in favor of `warnings.deprecated`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it's not deprecated, it's gone. It wasn't a public function tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure if we need a changelog for this because the change is 99% transparent for users, like they can't phisically measure any difference because the warnings are identical, same class, same message.
Summary
fixes: #1917
redo of: #2655 & #2828
https://canary.discord.com/channels/881207955029110855/903819190274764800/1453819292977201328
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.